svn commit: r357761 - head/sys/netinet

Michael Tuexen tuexen at freebsd.org
Tue Feb 11 23:11:07 UTC 2020


> On 11. Feb 2020, at 20:52, Gleb Smirnoff <glebius at freebsd.org> wrote:
> 
>  Michael,
> 
> On Tue, Feb 11, 2020 at 08:38:21PM +0100, Michael Tuexen wrote:
> M> I can revert it and get it working in a different way. However, the
> M> networking code uses ints for booleans in a lot of places. I wasn't
> M> aware that we need to use bool now.
> 
> We don't need to use bool, but we should use it in any new code.
> Some people may still drop ints into new code, and this can be
> tolerable, but intentionally converting from bools to ints is a
> move backwards and this isn't okay.
Ahh, OK. Thanks for the clarification.

Best regards
Michael
> 
> Thanks for redoing it with via ifdefs for legacy platforms.
> 
> -- 
> Gleb Smirnoff



More information about the svn-src-head mailing list