svn commit: r357703 - head/share/mk
Kyle Evans
kevans at FreeBSD.org
Sun Feb 9 18:53:54 UTC 2020
Author: kevans
Date: Sun Feb 9 18:53:53 2020
New Revision: 357703
URL: https://svnweb.freebsd.org/changeset/base/357703
Log:
mips: mark GOOGLETEST broken, due to no fault of its own
As explained in the comment; GOOGLETEST cannot currently be compiled on any
mips variant at the moment due to the cross toolchain seemingly using the
wrong spec and not pulling in libgcc. We'll be fine when llvm 10 lands, at
which point this should be reverted most expeditiously.
Modified:
head/share/mk/src.opts.mk
Modified: head/share/mk/src.opts.mk
==============================================================================
--- head/share/mk/src.opts.mk Sun Feb 9 15:13:56 2020 (r357702)
+++ head/share/mk/src.opts.mk Sun Feb 9 18:53:53 2020 (r357703)
@@ -348,7 +348,12 @@ BROKEN_OPTIONS+=LIB32
BROKEN_OPTIONS+=LIBSOFT
.endif
.if ${__T:Mmips*}
-BROKEN_OPTIONS+=SSP
+# GOOGLETEST cannot currently be compiled on mips due to external circumstances.
+# Notably, the freebsd-gcc port isn't linking in libgcc so we end up trying ot
+# link to a hidden symbol. LLVM would successfully link this in, but some of
+# the mips variants are broken under LLVM until LLVM 10. GOOGLETEST should be
+# marked no longer broken with the switch to LLVM.
+BROKEN_OPTIONS+=GOOGLETEST SSP
.endif
# EFI doesn't exist on mips, powerpc, sparc or riscv.
.if ${__T:Mmips*} || ${__T:Mpowerpc*} || ${__T:Msparc64} || ${__T:Mriscv*}
More information about the svn-src-head
mailing list