svn commit: r357640 - head/sys/net

Jeff Roberson jeff at FreeBSD.org
Thu Feb 6 20:47:51 UTC 2020


Author: jeff
Date: Thu Feb  6 20:47:50 2020
New Revision: 357640
URL: https://svnweb.freebsd.org/changeset/base/357640

Log:
  Temporarily force IFF_NEEDSEPOCH until drivers have been resolved.
  
  Recent network epoch changes have left some drivers unexpectedly broken
  and there is not yet a consensus on the correct fix.  This is patch is
  a minor performance impact until we can agree on the correct path
  forward.
  
  Reviewed by:	core, network, imp, glebius, hselasky
  Differential Revision:	https://reviews.freebsd.org/D23515

Modified:
  head/sys/net/if.c

Modified: head/sys/net/if.c
==============================================================================
--- head/sys/net/if.c	Thu Feb  6 20:32:53 2020	(r357639)
+++ head/sys/net/if.c	Thu Feb  6 20:47:50 2020	(r357640)
@@ -546,6 +546,8 @@ if_alloc_domain(u_char type, int numa_domain)
 #ifdef VIMAGE
 	ifp->if_vnet = curvnet;
 #endif
+	/* XXX */
+	ifp->if_flags |= IFF_NEEDSEPOCH;
 	if (if_com_alloc[type] != NULL) {
 		ifp->if_l2com = if_com_alloc[type](type, ifp);
 		if (ifp->if_l2com == NULL) {
@@ -4152,7 +4154,8 @@ if_setdrvflags(if_t ifp, int flags)
 int
 if_setflags(if_t ifp, int flags)
 {
-	((struct ifnet *)ifp)->if_flags = flags;
+	/* XXX Temporary */
+	((struct ifnet *)ifp)->if_flags = flags | IFF_NEEDSEPOCH;
 	return (0);
 }
 


More information about the svn-src-head mailing list