svn commit: r368606 - head/usr.bin/calendar

[Stefan Esser]

Am 13.12.20 um 12:13 schrieb Yuri Pankov:
> Stefan Eßer wrote:
>> Author: se
>> Date: Sun Dec 13 09:38:50 2020
>> New Revision: 368606
>> URL: https://svnweb.freebsd.org/changeset/base/368606
>>
>> Log:
>>    Fix WITHOUT_ICONV build
>>    There was an unprotected use of nl_langinfo() to determine the 
>> order of
>>    day vs. month in the generated output.
> 
> That's strange, nl_langinfo() is standard and its visibility should not 
> (and does not?) depend on WITH/WITHOUT_ICONV.  May be just move 
> langinfo.h include outside of "#ifdef WITH_ICONV" block?

Yes, you are perfectly right ...

I had noticed that WITHOUT_ICONV lead to a problem due to the missing 
prototype, but I had not seen that this was due to the include of
langinfo.h being conditional on WITH_ICONV.

I'll revert this commit and move the include of langinfo.h out of the
conditional block, as suggested by you.

Thanks for pointing this out!

Best regards, STefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20201213/df8c33b2/attachment.sig>