svn commit: r364822 - in head/crypto/openssl/crypto: aes/asm bn/asm chacha/asm ec/asm modes/asm poly1305/asm sha/asm

[Jessica Clarke]

On 26 Aug 2020, at 18:04, Mateusz Guzik <mjguzik at gmail.com> wrote:
> 
> On 8/26/20, Jung-uk Kim <jkim at freebsd.org> wrote:
>> Author: jkim
>> Date: Wed Aug 26 16:55:28 2020
>> New Revision: 364822
>> URL: https://svnweb.freebsd.org/changeset/base/364822
>> 
>> Log:
>>  Fix Clang version detection.
>> 
>>  We prepend "FreeBSD" to Clang version string.  This broke compiler test
>> for
>>  AVX instruction support.
>> 
> 
> What about other software checking in similar fashion? imo the right
> fix is to stop mucking with the way clang reports itself

Apple's LLVM also does the same thing. Whilst it may be better to leave
the string alone, it is sometimes useful information and, given the
existence of Apple's LLVM, well-behaved software should already be
dealing with this properly; based on this commit, upstream OpenSSL
seems like it suffers the same bug on macOS.

Jess