svn commit: r364488 - head/sys/kern

[Mateusz Guzik]

Author: mjg
Date: Sat Aug 22 16:58:59 2020
New Revision: 364488
URL: https://svnweb.freebsd.org/changeset/base/364488

Log:
  vfs: assert that HASBUF is only set with SAVENAME or SAVESTART
  
  as requested by the caller. The intent is to eradicate the mostly
  spurious NDFREE_PNBUF calls.

Modified:
  head/sys/kern/vfs_lookup.c

Modified: head/sys/kern/vfs_lookup.c
==============================================================================
--- head/sys/kern/vfs_lookup.c	Sat Aug 22 16:58:34 2020	(r364487)
+++ head/sys/kern/vfs_lookup.c	Sat Aug 22 16:58:59 2020	(r364488)
@@ -1384,6 +1384,7 @@ NDFREE_PNBUF(struct nameidata *ndp)
 {
 
 	if ((ndp->ni_cnd.cn_flags & HASBUF) != 0) {
+		MPASS((ndp->ni_cnd.cn_flags & (SAVENAME | SAVESTART)) != 0);
 		uma_zfree(namei_zone, ndp->ni_cnd.cn_pnbuf);
 		ndp->ni_cnd.cn_flags &= ~HASBUF;
 	}