svn commit: r359776 - head/sys/dev/sound/pci/hda

Ed Maste emaste at FreeBSD.org
Fri Apr 10 18:13:30 UTC 2020


Author: emaste
Date: Fri Apr 10 18:13:29 2020
New Revision: 359776
URL: https://svnweb.freebsd.org/changeset/base/359776

Log:
  hdac: update comment on reset duration
  
  The comment previously stated the delay must be at least 250us but that
  was insufficient and so should be doubled, but the delay was actually
  1000.  The HDA spec actually says the delay must be 521 us (25 frames)
  so update the comment to match.

Modified:
  head/sys/dev/sound/pci/hda/hdac.c

Modified: head/sys/dev/sound/pci/hda/hdac.c
==============================================================================
--- head/sys/dev/sound/pci/hda/hdac.c	Fri Apr 10 16:27:27 2020	(r359775)
+++ head/sys/dev/sound/pci/hda/hdac.c	Fri Apr 10 18:13:29 2020	(r359776)
@@ -440,9 +440,7 @@ hdac_reset(struct hdac_softc *sc, int wakeup)
 
 	/*
 	 * Wait for codecs to finish their own reset sequence. The delay here
-	 * should be of 250us but for some reasons, it's not enough on my
-	 * computer. Let's use twice as much as necessary to make sure that
-	 * it's reset properly.
+	 * must be at least 521us (HDA 1.0a section 4.3 Codec Discovery).
 	 */
 	DELAY(1000);
 


More information about the svn-src-head mailing list