svn commit: r359647 - in head/sys: arm64/broadcom arm64/broadcom/brcmmdio conf dev/mdio

[Peter Jeremy]

On 2020-Apr-06 05:48:58 +0000, Wojciech Macek <wma at FreeBSD.org> wrote:
>Log:
>  Add MDIO PHY driver for NS2 ARM64 platform.
...
>Modified: head/sys/conf/files.arm64
>==============================================================================
>--- head/sys/conf/files.arm64	Mon Apr  6 04:06:15 2020	(r359646)
>+++ head/sys/conf/files.arm64	Mon Apr  6 05:48:58 2020	(r359647)
>@@ -176,6 +176,9 @@ arm64/arm64/undefined.c		standard
> arm64/arm64/unwind.c		optional	ddb | kdtrace_hooks | stack
> arm64/arm64/vfp.c		standard
> arm64/arm64/vm_machdep.c	standard
>+arm64/broadcom/brcmmdio/mdio_mux_iproc.c	optional	fdt
>+arm64/broadcom/brcmmdio/mdio_nexus_iproc.c	optional	fdt
>+arm64/broadcom/brcmmdio/mdio_ns2_pcie_phy.c	optional	fdt pci

I don't believe this is correct.  These files are only relevant to a subset
of Broadcom SoCs and (IMO) should not be included merely with "options FDT",
rather they should be conditional on the relevant Broadcom SoCs.

-- 
Peter Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20200407/4278c9f7/attachment.sig>