svn commit: r352795 - head/lib/libc/sys
Mateusz Guzik
mjguzik at gmail.com
Fri Sep 27 18:32:22 UTC 2019
On 9/27/19, Warner Losh <imp at freebsd.org> wrote:
> Author: imp
> Date: Fri Sep 27 16:11:47 2019
> New Revision: 352795
> URL: https://svnweb.freebsd.org/changeset/base/352795
>
> Log:
> Document varadic args as int, since you can't have short varadic args
> (they are
> promoted to ints).
>
> - `mode_t` is `uint16_t` (`sys/sys/_types.h`)
> - `openat` takes variadic args
> - variadic args cannot be 16-bit, and indeed the code uses int
> - the manpage currently kinda implies the argument is 16-bit by saying
> `mode_t`
>
> Prompted by Rust things: https://github.com/tailhook/openat/issues/21
> Submitted by: Greg V at unrelenting
> Differential Revision: https://reviews.freebsd.org/D21816
>
> Modified:
> head/lib/libc/sys/mq_open.2
> head/lib/libc/sys/open.2
>
> Modified: head/lib/libc/sys/mq_open.2
> ==============================================================================
> --- head/lib/libc/sys/mq_open.2 Fri Sep 27 15:28:30 2019 (r352794)
> +++ head/lib/libc/sys/mq_open.2 Fri Sep 27 16:11:47 2019 (r352795)
> @@ -133,7 +133,7 @@ Create a message queue.
> It requires two additional arguments:
> .Fa mode ,
> which is of type
> -.Vt mode_t ,
> +.Vt int ,
> and
> .Fa attr ,
> which is a pointer to an
>
> Modified: head/lib/libc/sys/open.2
> ==============================================================================
> --- head/lib/libc/sys/open.2 Fri Sep 27 15:28:30 2019 (r352794)
> +++ head/lib/libc/sys/open.2 Fri Sep 27 16:11:47 2019 (r352795)
> @@ -61,7 +61,7 @@ In this case
> and
> .Fn openat
> require an additional argument
> -.Fa "mode_t mode" ,
> +.Fa "int mode" ,
> and the file is created with mode
> .Fa mode
> as described in
>
But opengroup says it is mode_t. Perhaps it is mode_t which needs
to be changed?
--
Mateusz Guzik <mjguzik gmail.com>
More information about the svn-src-head
mailing list