svn commit: r352671 - head/sbin/nvmecontrol

Warner Losh imp at FreeBSD.org
Wed Sep 25 07:51:31 UTC 2019


Author: imp
Date: Wed Sep 25 07:51:30 2019
New Revision: 352671
URL: https://svnweb.freebsd.org/changeset/base/352671

Log:
  Size is unsigned, so remove the test entirely.
  
  The kernel won't crash if you have a bad value and I'd rather not have
  nvmecontrol know the internal details about how the nvme driver limits
  the transfer size.

Modified:
  head/sbin/nvmecontrol/perftest.c

Modified: head/sbin/nvmecontrol/perftest.c
==============================================================================
--- head/sbin/nvmecontrol/perftest.c	Wed Sep 25 07:36:35 2019	(r352670)
+++ head/sbin/nvmecontrol/perftest.c	Wed Sep 25 07:51:30 2019	(r352671)
@@ -177,10 +177,6 @@ perftest(const struct cmd *f, int argc, char *argv[])
 		arg_help(argc, argv, f);
 	}
 	io_test.time = opt.time;
-	if (opt.size < 0) {
-		fprintf(stderr, "Invalid size.\n");
-		arg_help(argc, argv, f);
-	}
 	io_test.size = opt.size;
 	open_dev(opt.dev, &fd, 1, 1);
 	if (ioctl(fd, ioctl_cmd, &io_test) < 0)


More information about the svn-src-head mailing list