svn commit: r352275 - in head/lib/libedit: . TEST edit readline

[Peter Jeremy]

On 2019-Sep-13 16:33:15 -0400, Charlie Li <ml+freebsd at vishwin.info> wrote:
>Baptiste Daroussin wrote:
>> Author: bapt
>> Date: Fri Sep 13 06:50:02 2019
>> New Revision: 352275
>> URL: https://svnweb.freebsd.org/changeset/base/352275
>> 
>> Log:
>>   Update libedit to a snapshot from 2019-09-10
>>   Reviewed by:	Yuichiro Naito <naito.yuichiro_gmail.com>
>>   MFC after:	3 weeks
>>   Differential Revision:	https://reviews.freebsd.org/D21584
>> 
>I posted in phab but repeating here, this breaks the build on (at least)
>aarch64:

It breaks the build on arm and arm64 only.

wint_t is int on all platforms:
sys/sys/_types.h:
typedef int             __ct_rune_t;    /* arg type for ctype funcs */
typedef __ct_rune_t     __wint_t;       /* wint_t (see above) */

but wchar_t varies between unsigned and signed:
$ grep '__wchar_t' sys/*/include/_types.h 
sys/arm/include/_types.h:typedef        unsigned int    ___wchar_t;
sys/arm64/include/_types.h:typedef      unsigned int    ___wchar_t;
sys/mips/include/_types.h:typedef       int             ___wchar_t;
sys/powerpc/include/_types.h:typedef    int             ___wchar_t;
sys/riscv/include/_types.h:typedef      int             ___wchar_t;
sys/sparc64/include/_types.h:typedef    int             ___wchar_t;
sys/x86/include/_types.h:typedef        int             ___wchar_t;

Looking back into history, it looks like the "unsigned" is part
of the ARM EABI.

-- 
Peter Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20190914/6792a243/attachment.sig>