svn commit: r352092 - head/sbin/bectl

[Kyle Evans]

Author: kevans
Date: Mon Sep  9 18:17:30 2019
New Revision: 352092
URL: https://svnweb.freebsd.org/changeset/base/352092

Log:
  bectl(8): initialize reverse earlier
  
  This turns into a warning in GCC 4.2 that 'reverse' may be used
  uninitialized in this function. While I don't immediately see where it's
  deciding this from (there's only two paths that make column != NULL, and
  they both set reverse), initializing reverse earlier is good for clarity.
  
  MFC after:	3 days

Modified:
  head/sbin/bectl/bectl_list.c

Modified: head/sbin/bectl/bectl_list.c
==============================================================================
--- head/sbin/bectl/bectl_list.c	Mon Sep  9 18:07:31 2019	(r352091)
+++ head/sbin/bectl/bectl_list.c	Mon Sep  9 18:17:30 2019	(r352092)
@@ -412,6 +412,7 @@ bectl_cmd_list(int argc, char *argv[])
 	props = NULL;
 	printed = 0;
 	bzero(&pc, sizeof(pc));
+	reverse = false;
 	while ((opt = getopt(argc, argv, "aDHsc:C:")) != -1) {
 		switch (opt) {
 		case 'a':
@@ -463,10 +464,8 @@ bectl_cmd_list(int argc, char *argv[])
 	}
 
 	/* List boot environments in alphabetical order by default */
-	if (column == NULL) {
+	if (column == NULL)
 		column = strdup("name");
-		reverse = false;
-	}
 
 	prop_list_sort(props, column, reverse);