svn commit: r346039 - head/sys/conf

[Rebecca Cran]

On 2019-04-08 12:25, Warner Losh wrote:
> Author: imp
> Date: Mon Apr  8 18:25:14 2019
> New Revision: 346039
> URL: https://svnweb.freebsd.org/changeset/base/346039
>
> Log:
>    Style only change: Prefer $() to ``
>    
>    $() is more modern and also nests. Convert the mix of styles to using
>    only the former (although the latter was more common). It's the more
>    dominant style in other shell scripts these days as well.
>    
>    Differential Revision:  https://reviews.freebsd.org/D19840
>
> Modified:
>    head/sys/conf/newvers.sh
>
> Modified: head/sys/conf/newvers.sh


I thought I saw an email a few weeks ago that suggested that the list of 
people who reviewed the patch should be copied into a "Reviewed by:" 
line, to avoid only having that information in Phabricator.

Am I remembering correctly, or is just mentioning the Phab review 
considered sufficient?


-- 
Rebecca Cran