svn commit: r351643 - in head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common: dtraceUtil speculation

Enji Cooper yaneurabeya at gmail.com
Sun Sep 1 18:07:08 UTC 2019


> On Aug 31, 2019, at 16:29, Warner Losh <imp at bsdimp.com> wrote:
> 
> 
> 
>> On Sat, Aug 31, 2019 at 5:29 PM Conrad Meyer <cem at freebsd.org> wrote:
>> Thanks Li-Wen!  Might it be less fragile to have the test fixture
>> create a file, if the test(s) will expect one to be present to read?
> 
> Or just use the realpath $0, which you know has to exist :)

I don’t know if this would work, with other some of the dtrace tests are called. Plus, that relies on a FreeBSD utility which doesn’t necessarily exist on Linux and I don’t think exists on IllumOS.

It makes more sense to create a file with mktemp and test for it in the loop to make the tests portable over to IllumOS, since that’s where they originally came from and can be contributed back to.

Thanks,
-Enji


More information about the svn-src-head mailing list