svn commit: r354121 - in head/tests/sys/netpfil: common pf

[Kristof Provost]

On 2019-10-26 21:19:55 (+0000), Bjoern A. Zeeb <bz at FreeBSD.org> wrote:
> Author: bz
> Date: Sat Oct 26 21:19:55 2019
> New Revision: 354121
> URL: https://svnweb.freebsd.org/changeset/base/354121
> 
> Log:
>   Upgrade (scapy) py2 tests to work on py3.
>   
>   In order to move python2 out of the test framework to avoid py2 vs. py3
>   confusions upgrade the remaining test cases using scapy to work with py3.
>   That means only one version of scapy needs to be installed in the CI system.
>   It also gives a path forward for testing i386 issues observed in the CI
>   system with some of these tests.
>   
>   Fixes are:
>   - Use default python from environment (which is 3.x these days).
>   - properly ident some lines as common for the rest of the file to avoid
>     errors.
>   - cast the calculated offset to an int as the division result is considered
>     a float which is not accepted input.
>   - when comparing payload to a magic number make sure we always add the
>     payload properly to the packet and do not try to compare string in
>     the result but convert the data payload back into an integer.
>   - fix print formating.
>   
>   Discussed with:	lwhsu, kp (taking it off his todo :)

Thank you!

Kristof