svn commit: r353848 - head/sys/dev/jme

[Gleb Smirnoff]

  Sergey,

On Mon, Oct 21, 2019 at 11:30:46PM +0300, Sergey Kandaurov wrote:
S> >         struct ifnet *ifp;
S> > -       struct ifmultiaddr *ifma;
S> > -       uint32_t crc;
S> >         uint32_t mchash[2];
S> >         uint32_t rxcfg;
S> >
S> > @@ -3276,21 +3290,7 @@ jme_set_filter(struct jme_softc *sc)
S> >          */
S> >         rxcfg |= RXMAC_MULTICAST;
S> >         bzero(mchash, sizeof(mchash));
S> > -
S> > -       if_maddr_rlock(ifp);
S> > -       CK_STAILQ_FOREACH(ifma, &sc->jme_ifp->if_multiaddrs, ifma_link) {
S> > -               if (ifma->ifma_addr->sa_family != AF_LINK)
S> > -                       continue;
S> > -               crc = ether_crc32_be(LLADDR((struct sockaddr_dl *)
S> > -                   ifma->ifma_addr), ETHER_ADDR_LEN);
S> > -
S> > -               /* Just want the 6 least significant bits. */
S> > -               crc &= 0x3f;
S> > -
S> > -               /* Set the corresponding bit in the hash table. */
S> > -               mchash[crc >> 5] |= 1 << (crc & 0x1f);
S> > -       }
S> > -       if_maddr_runlock(ifp);
S> > +       if_foreach_llmaddr(ifp, jme_hash_maddr, &mchash);
S> >
S> 
S> Should not be there just “mchash”?
S> You seems to be passing (uint32_t **),
S> also in tsec.

mchash and &mchash are the same here.

-- 
Gleb Smirnoff