svn commit: r352909 - in head: contrib/elftoolchain/nm usr.bin/nm

[Mark Johnston]

On Thu, Oct 17, 2019 at 01:05:42PM -0600, Alan Somers wrote:
> On Thu, Oct 17, 2019 at 12:48 PM Ian Lepore <ian at freebsd.org> wrote:
> 
> > On Thu, 2019-10-17 at 12:17 -0600, Alan Somers wrote:
> > > There might be something wrong with my environment:
> > > /usr/include/libcasper.h is absent.  But still, shouldn't the build
> > > be
> > > using the version from the source tree, instead of from the
> > > environment?
> > > -Alan
> > >
> >
> > There should be copies of libcasper.h in your objdir:
> >
> > obj/arm.armv7/tmp/legacy/usr/include/libcasper.h
> > obj/arm.armv7/tmp/usr/include/libcasper.h
> >
> > -- Ian
> 
> 
> Uh, I found the problem.  I had WITHOUT_CASPER=1 in /etc/src.conf.  So the
> problem is that nm can't build without casper.  Perhaps the #include should
> be guarded, as it is in usr.bin/kdump/kdump.c.  But plenty of other
> programs, like usr.bin/tail and usr.bin/wc, don't have such guards.  And
> looking at lib/libcasper/libcasper/Makefile, it seems as though libcasper.h
> should be installed regardless.  So I still need to figure out why it
> wasn't installed on my system.

Indeed, "make -C usr.bin/nm WITHOUT_CASPER=" builds fine for me.
libcasper.h provides stub routines unless WITH_CASPER is defined in the
preprocessor, so applications which make use of casper must define this
symbol unless the make variable WITHOUT_CASPER is set.