svn commit: r353599 - head/sys/dev/ixgbe

Eric Joyner erj at FreeBSD.org
Tue Oct 15 21:56:20 UTC 2019


Author: erj
Date: Tue Oct 15 21:56:19 2019
New Revision: 353599
URL: https://svnweb.freebsd.org/changeset/base/353599

Log:
  ixgbe: Disable EEE for backplane X550EM_X
  
  From Zach:
  Intel documentation indicates that backplane X550EM_X KR devices do not
  support Energy Efficient Ethernet. Prior to this patch, X552 devices
  (device ID 0x15AB) will crash the system when transitioning EEE state
  via sysctl.
  
  Signed-off-by: Zach Vargas <zvargas at xes-inc.com>
  
  PR:		240320
  Submitted by:	Zach Vargas <zvargas at xes-inc.com>
  Reviewed by:	erj@
  MFC after:	3 days
  Differential Revision:	https://reviews.freebsd.org/D21673

Modified:
  head/sys/dev/ixgbe/if_ix.c

Modified: head/sys/dev/ixgbe/if_ix.c
==============================================================================
--- head/sys/dev/ixgbe/if_ix.c	Tue Oct 15 21:32:38 2019	(r353598)
+++ head/sys/dev/ixgbe/if_ix.c	Tue Oct 15 21:56:19 2019	(r353599)
@@ -4414,7 +4414,7 @@ ixgbe_sysctl_eee_state(SYSCTL_HANDLER_ARGS)
 	if ((new_eee < 0) || (new_eee > 1))
 		return (EINVAL);
 
-	retval = adapter->hw.mac.ops.setup_eee(&adapter->hw, new_eee);
+	retval = ixgbe_setup_eee(&adapter->hw, new_eee);
 	if (retval) {
 		device_printf(dev, "Error in EEE setup: 0x%08X\n", retval);
 		return (EINVAL);
@@ -4467,8 +4467,6 @@ ixgbe_init_device_features(struct adapter *adapter)
 	case ixgbe_mac_X550EM_x:
 		adapter->feat_cap |= IXGBE_FEATURE_SRIOV;
 		adapter->feat_cap |= IXGBE_FEATURE_FDIR;
-		if (adapter->hw.device_id == IXGBE_DEV_ID_X550EM_X_KR)
-			adapter->feat_cap |= IXGBE_FEATURE_EEE;
 		break;
 	case ixgbe_mac_X550EM_a:
 		adapter->feat_cap |= IXGBE_FEATURE_SRIOV;


More information about the svn-src-head mailing list