svn commit: r353119 - head/sys/netinet

[Michael Tuexen]

Author: tuexen
Date: Sat Oct  5 09:46:11 2019
New Revision: 353119
URL: https://svnweb.freebsd.org/changeset/base/353119

Log:
  Fix the adding of padding to COOKIE-ECHO chunks.
  
  Thanks to Mark Wodrich who found this issue while fuzz testing the
  usrsctp stack and reported the issue in
  https://github.com/sctplab/usrsctp/issues/382
  
  MFC after:		3 days

Modified:
  head/sys/netinet/sctp_output.c

Modified: head/sys/netinet/sctp_output.c
==============================================================================
--- head/sys/netinet/sctp_output.c	Sat Oct  5 03:19:53 2019	(r353118)
+++ head/sys/netinet/sctp_output.c	Sat Oct  5 09:46:11 2019	(r353119)
@@ -9059,8 +9059,7 @@ sctp_send_cookie_echo(struct mbuf *m,
 				pad = 4 - pad;
 			}
 			if (pad > 0) {
-				cookie = sctp_pad_lastmbuf(cookie, pad, NULL);
-				if (cookie == NULL) {
+				if (sctp_pad_lastmbuf(cookie, pad, NULL) == NULL) {
 					return (-8);
 				}
 			}