svn commit: r352312 - in head: lib/geom/nop sys/geom/nop

Chuck Silvers chs at freebsd.org
Wed Oct 2 22:08:15 UTC 2019


On Wed, Oct 02, 2019 at 08:11:57AM -0600, Alan Somers wrote:
> On Fri, Sep 13, 2019 at 5:04 PM Chuck Silvers <chs at freebsd.org> wrote:
> 
> > Author: chs
> > Date: Fri Sep 13 23:03:56 2019
> > New Revision: 352312
> > URL: https://svnweb.freebsd.org/changeset/base/352312
> >
> > Log:
> >   Add a "count_until_fail" option to gnop, which says to start failing
> >   I/O requests after the given number have been allowed though.
> >
> >   Approved by:    imp (mentor)
> >   Reviewed by:    rpokala kib 0mp mckusick
> >   Sponsored by:   Netflix
> >   Differential Revision:  https://reviews.freebsd.org/D21593
> >
> > Modified:
> >   head/lib/geom/nop/geom_nop.c
> >   head/lib/geom/nop/gnop.8
> >   head/sys/geom/nop/g_nop.c
> >   head/sys/geom/nop/g_nop.h
> >
> 
> This patch introduces a backwards-compatibility bug.  On a system with a
> post-352312 kernel but a pre-352312 userland, the gnop command will always
> fail with the error "gnop: Missing count_until_fail argument".
> -Alan

Thanks for pointing this out, I'll see about fixing it right away.

-Chuck


More information about the svn-src-head mailing list