svn commit: r352925 - head/sys/dev/xen/control

[Ravi Pokala]

-----Original Message-----
From: Roger Pau Monné <royger at FreeBSD.org>
Date: 2019-10-02, Wednesday at 00:53
To: Ravi Pokala <rpokala at freebsd.org>
Cc: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
Subject: Re: svn commit: r352925 - head/sys/dev/xen/control

    On Tue, Oct 01, 2019 at 06:42:14PM -0700, Ravi Pokala wrote:
    > Hi Roger,
    > 
    > If I'm understanding this diff correctly, all of (poweroff, reboot, suspend) will use the common string "shutdown", rather than an event-specific string. Is that what we want?
    
    I think there's some misunderstanding here. All power control events
    use the same xenstore node (~/control/shutdown), but the command read
    from it is different depending on the requested action (poweroff,
    reboot, halt...).

Ah! Yes indeed, that was a misunderstanding on my part. I thought "shutdown" was the command text, rather than a component of the path containing the command.

    See [0] for a slightly more detailed description of the xenstore node.
    
    Note that this commit doesn't change any of this logic, it just clears
    the contents of ~/control/shutdown (by writing "") so the toolstack
    knows FreeBSD has acknowledged the request and it's processing it.

Yes, that all makes sense.

Thanks for clarifying!

-Ravi (rpokala@)

    Roger.
    
    [0] http://xenbits.xen.org/docs/4.12-testing/misc/xenstore-paths.html#platform-feature-and-control-paths