svn commit: r352940 - head/sys/dev/usb/controller

[Warner Losh]

On Tue, Oct 1, 2019, 2:34 PM Emmanuel Vadot <manu at bidouilliste.com> wrote:

> On Tue, 01 Oct 2019 14:29:58 -0600
> Ian Lepore <ian at freebsd.org> wrote:
>
> > On Tue, 2019-10-01 at 20:21 +0000, Emmanuel Vadot wrote:
> > > Author: manu
> > > Date: Tue Oct  1 20:21:49 2019
> > > New Revision: 352940
> > > URL: https://svnweb.freebsd.org/changeset/base/352940
> > >
> > > Log:
> > >   generic_ohci: Look for the phy based on the id
> > >
> > >   phy-names was never in the bindings schema even if it was present
> > >   in some DTS. Get the optional phy based on its ID.
> > >
> >
> > The phys= property comes from the generic phys.txt binding, and in
> > there, it says that phy-names= is mandatory if phys= is present.  There
> > used to be a usb_phy= property that didn't have a corresponding names
> > property, but I can't even find the binding doc that mentions it
> > anymore; it probably got deprecated why the generic phys binding was
> > created.
> >
> > -- Ian
>
>  Huh right, I've missed the phy-bindings.txt document somehow, I'll go
> complain on the linux ML then.
>

They are always eager for examples of breakage.

Warner

-- 
> Emmanuel Vadot <manu at bidouilliste.com> <manu at freebsd.org>
>