svn commit: r354909 - in head: . share/mk
Glen Barber
gjb at freebsd.org
Thu Nov 21 16:13:42 UTC 2019
On Wed, Nov 20, 2019 at 06:36:58PM +0000, Brooks Davis wrote:
> Author: brooks
> Date: Wed Nov 20 18:36:58 2019
> New Revision: 354909
> URL: https://svnweb.freebsd.org/changeset/base/354909
>
> Log:
> Make the warning for deprecated NO_ variables an error.
>
> Support for NO_CTF, NO_DEBUG_FILES, NO_INSTALLLIB, NO_MAN, NO_PROFILE,
> and NO_WARNS as deprecated in 2014 with a warning added for each one
> found. Turn these into error in preperation for removal of compatability
> support before FreeBSD 13.
>
> Reviewed by: imp
> Relnotes: yes
> Sponsored by: DARPA, AFRL
> Differential Revision: https://reviews.freebsd.org/D22448
>
> Modified: head/share/mk/bsd.opts.mk
> ==============================================================================
> --- head/share/mk/bsd.opts.mk Wed Nov 20 18:12:01 2019 (r354908)
> +++ head/share/mk/bsd.opts.mk Wed Nov 20 18:36:58 2019 (r354909)
> @@ -100,7 +100,7 @@ __DEFAULT_DEPENDENT_OPTIONS = \
> PROFILE \
> WARNS
> .if defined(NO_${var})
> -.warning "NO_${var} is defined, but deprecated. Please use MK_${var}=no instead."
> +.error "NO_${var} is defined, but deprecated. Please use MK_${var}=no instead."
> MK_${var}:=no
> .endif
> .endfor
>
Had this been exp-run tested? This breaks at least the
net/bsdec2-image-upload port, which does *not* set NO_MAN explicitly in
its Makefile. I suspect at least several other ports are now implicitly
broken as result of this change.
Glen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20191121/11296bca/attachment.sig>
More information about the svn-src-head
mailing list