svn commit: r354703 - head/sys/dev/ioat

[Alexander Motin]

On 14.11.2019 05:11, Konstantin Belousov wrote:
> On Thu, Nov 14, 2019 at 04:39:49AM +0000, Alexander Motin wrote:
>> Author: mav
>> Date: Thu Nov 14 04:39:48 2019
>> New Revision: 354703
>> URL: https://svnweb.freebsd.org/changeset/base/354703
>>
>> Log:
>>   Pass more reasonable WAIT flags to bus_dma(9) calls.
>>   
>>   MFC after:	2 weeks
>>
>> Modified:
>>   head/sys/dev/ioat/ioat.c
>>
>> Modified: head/sys/dev/ioat/ioat.c
>> ==============================================================================
>> --- head/sys/dev/ioat/ioat.c	Thu Nov 14 04:34:58 2019	(r354702)
>> +++ head/sys/dev/ioat/ioat.c	Thu Nov 14 04:39:48 2019	(r354703)
>> @@ -555,13 +555,14 @@ ioat3_attach(device_t device)
>>  	    &ioat->comp_update_tag);
>>  
>>  	error = bus_dmamem_alloc(ioat->comp_update_tag,
>> -	    (void **)&ioat->comp_update, BUS_DMA_ZERO, &ioat->comp_update_map);
>> +	    (void **)&ioat->comp_update, BUS_DMA_ZERO | BUS_DMA_WAITOK,
>> +	    &ioat->comp_update_map);
> For waitok, you need to provide locking function in the tag.

I'm sorry, but why?  It is alloc(), not load().  For load() it makes
sense since it calls back, but this is just a form of malloc(), isn't
it?  I've looked through the both x86 implementations and found nothing
suspicious.

-- 
Alexander Motin