svn commit: r348451 - head/sys/fs/nfsclient

Rick Macklem rmacklem at FreeBSD.org
Fri May 31 00:56:32 UTC 2019


Author: rmacklem
Date: Fri May 31 00:56:31 2019
New Revision: 348451
URL: https://svnweb.freebsd.org/changeset/base/348451

Log:
  Clean up silly code case.
  
  This silly code segment has existed in the sources since it was brought
  into FreeBSD 10 years ago. I honestly have no idea why this was done.
  It was possible that I thought that it might have been better to not
  set B_ASYNC for the "else" case, but I can't remember.
  Anyhow, this patch gets rid of the if/else that does the same thing
  either way, since it looks silly and upsets a static analyser.
  This will have no semantic effect on the NFS client.
  
  PR:		238167

Modified:
  head/sys/fs/nfsclient/nfs_clvnops.c

Modified: head/sys/fs/nfsclient/nfs_clvnops.c
==============================================================================
--- head/sys/fs/nfsclient/nfs_clvnops.c	Fri May 31 00:00:03 2019	(r348450)
+++ head/sys/fs/nfsclient/nfs_clvnops.c	Fri May 31 00:56:31 2019	(r348451)
@@ -2940,10 +2940,7 @@ loop:
 		}
 		BO_UNLOCK(bo);
 		bremfree(bp);
-		if (passone || !commit)
-		    bp->b_flags |= B_ASYNC;
-		else
-		    bp->b_flags |= B_ASYNC;
+		bp->b_flags |= B_ASYNC;
 		bwrite(bp);
 		if (newnfs_sigintr(nmp, td)) {
 			error = EINTR;


More information about the svn-src-head mailing list