svn commit: r348355 - head/sys/dev/iicbus
Andriy Gapon
avg at FreeBSD.org
Wed May 29 12:41:41 UTC 2019
On 29/05/2019 14:54, Niclas Zeising wrote:
> On 2019-05-29 11:08, Andriy Gapon wrote:
>> Author: avg
>> Date: Wed May 29 09:08:20 2019
>> New Revision: 348355
>> URL: https://svnweb.freebsd.org/changeset/base/348355
>>
>> Log:
>> revert r273728 and parts of r306589, iicbus no-stop by default feature
>> Since drm2 removal, there has not been any consumer of the feature in the
>> tree. I am also unaware of any out-of-tree consumer.
>> More importantly, the feature has been broken from the very start, both
>> before and after r306589, because the ivar was set on a device that does
>> not support it and it was read from another device that also does not
>> support it.
>> A bus-wide no-stop flag cannot be implemented as an ivar as iicbus
>> attaches as a child of various drivers. Implementing the ivar in each
>> and every I2C driver is just impractical.
>> If we ever want to implement this feature properly, then probably the
>> easiest way to do it would be via a flag in the softc of iicbus.
>> In fact, we might have to do that in the stable branches if we want to
>> fix the code for them.
>> Reported by: ian (long time ago)
>> MFC after: 1 month (maybe)
>> X-MFC-note: cannot just merge the change, must keep drm2 happy
>>
>
> Hi!
> Just a note, be aware that drm2 lives on in ports as drm-legacy-kmod. I haven't
> tested, but, from the description above I worry that it will affect the port.
> What do you think?
Oh, I forgot about that one...
I think that it could be affected if it still uses FreeBSD iic code.
I guess I might have to revert the change.
--
Andriy Gapon
More information about the svn-src-head
mailing list