svn commit: r310524 - in head/sys/cam: ctl scsi

[Alexey Dokuchaev]

On Wed, May 22, 2019 at 11:40:42AM -0400, Alexander Motin wrote:
> On 22.05.2019 11:21, Alexey Dokuchaev wrote:
> > On Sat, Dec 24, 2016 at 05:42:34PM +0000, Alexander Motin wrote:
> >> New Revision: 310524
> >> URL: https://svnweb.freebsd.org/changeset/base/310524
> >>
> >> Modified: head/sys/cam/scsi/scsi_all.c
> >> ...
> >> +			}
> >> +			if (len > sizeof(sense->cmd_spec_info)) {
> >> +				data += len - sizeof(sense->cmd_spec_info);
> >> +				len -= len - sizeof(sense->cmd_spec_info);
> > 
> > PVS Studio complains here: error: V765 A compound assignment expression 'x
> > -= x - ...' is suspicious. Consider inspecting it for a possible error.
> > 
> > This "len -= len - sizeof(...)" indeed looks weird, can you take a look?
> 
> It may be weird, but not incorrect.  Fixed though.

Wow that was fast!  Thanks (for both commits),

./danfe