svn commit: r347263 - head/sys/dev/mlx5/mlx5_en

Hans Petter Selasky hselasky at FreeBSD.org
Wed May 8 10:35:36 UTC 2019


Author: hselasky
Date: Wed May  8 10:35:35 2019
New Revision: 347263
URL: https://svnweb.freebsd.org/changeset/base/347263

Log:
  Disable CQE zipping by default in mlx5en(4).
  
  After doing performance measurements, it seems like CQE zipping doesn't
  have any significant benefit.
  Moreover, we know that this feature is disabled by default on other
  operating systems (Linux for example).
  
  Submitted by:	slavash@
  MFC after:	3 days
  Sponsored by:	Mellanox Technologies

Modified:
  head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c

Modified: head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
==============================================================================
--- head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c	Wed May  8 10:35:14 2019	(r347262)
+++ head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c	Wed May  8 10:35:35 2019	(r347263)
@@ -3175,7 +3175,12 @@ mlx5e_build_ifp_priv(struct mlx5_core_dev *mdev,
 	priv->params.hw_lro_en = false;
 	priv->params.lro_wqe_sz = MLX5E_PARAMS_DEFAULT_LRO_WQE_SZ;
 
-	priv->params.cqe_zipping_en = !!MLX5_CAP_GEN(mdev, cqe_compression);
+	/*
+	 * CQE zipping is currently defaulted to off. when it won't
+	 * anymore we will consider the HW capability:
+	 * "!!MLX5_CAP_GEN(mdev, cqe_compression)"
+	 */
+	priv->params.cqe_zipping_en = false;
 
 	priv->mdev = mdev;
 	priv->params.num_channels = num_comp_vectors;


More information about the svn-src-head mailing list