svn commit: r347063 - head/sys/kern
John Baldwin
jhb at FreeBSD.org
Tue May 7 16:40:21 UTC 2019
On 5/7/19 8:45 AM, Bruce Evans wrote:
> On Mon, 6 May 2019, John Baldwin wrote:
>
>> On 5/6/19 11:45 AM, Mark Johnston wrote:
>>> On Mon, May 06, 2019 at 11:07:18AM -0700, John Baldwin wrote:
>>>> On 5/3/19 2:26 PM, Mark Johnston wrote:
>>>>> Author: markj
>>>>> Date: Fri May 3 21:26:44 2019
>>>>> New Revision: 347063
>>>>> URL: https://svnweb.freebsd.org/changeset/base/347063
>>>>>
>>>>> Log:
>>>>> Disallow excessively small times of day in clock_settime(2).
>
> This actually disallows negative timespecs in clock_settime(), with
> collateral disallowment for small positive times.
FWIW, clock_settime already disallows negative times due to the
existing check in the previous two lines:
if (ats->tv_nsec < 0 || ats->tv_nsec >= 1000000000 ||
ats->tv_sec < 0)
return (EINVAL);
I would probably lean towards not disallowing negative times as I
said in one of my earlier replies, but given we have that blanket
check already in place, the current patch doesn't seem to make
things much worse.
--
John Baldwin
More information about the svn-src-head
mailing list