svn commit: r347218 - head/sys/compat/linsysfs

Rodney W. Grimes freebsd at gndrsh.dnsmgr.net
Tue May 7 05:32:06 UTC 2019


> Author: dchagin
> Date: Tue May  7 05:08:13 2019
> New Revision: 347218
> URL: https://svnweb.freebsd.org/changeset/base/347218
> 
> Log:
>   Remove wrong copyright line. Discussed with Carlos Neira.
>   
>   Reported by:	Rodney W. Grimes
normally just use a committers username, aka rgrimes or rgrimes@
for these types of things.

>   MFC after:	2 weeks
>   Differential Revision:	https://reviews.freebsd.org/D13656

Hang on, now you removed his copyright?
I see he said that was ok, but that was not the desired intent here. 
It would of been fine to have the copyright read:

 * Copyright (c) 2006 IronPort Systems
 * All rights reserved.
 * Copyright (c) 2017 Carlos Neira cneirabustos at gmail.com

As a heads up to other committers you should never insert your
copyright between another copyright and the "All rights reserved." text,
if you wish to assert the all rights reserved you should duplicate
it like:

 * Copyright (c) 2006 IronPort Systems
 * All rights reserved.
 * Copyright (c) 2017 Carlos Neira cneirabustos at gmail.com
 * All rights reserved.

preferably on the line with your copyright as in:
 * Copyright (c) 2017 Carlos Neira cneirabustos at gmail.com All rights reserved.

But if at all possible it would be best if we could not add any
more of these, and remove them when possible.

For those wishing to save space the (c) is unneeded when you
spell out the word "Copyright".

> 
> Modified:
>   head/sys/compat/linsysfs/linsysfs.c
> 
> Modified: head/sys/compat/linsysfs/linsysfs.c
> ==============================================================================
> --- head/sys/compat/linsysfs/linsysfs.c	Tue May  7 01:27:23 2019	(r347217)
> +++ head/sys/compat/linsysfs/linsysfs.c	Tue May  7 05:08:13 2019	(r347218)
> @@ -2,7 +2,6 @@
>   * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
>   *
>   * Copyright (c) 2006 IronPort Systems
> - * Copyright (c) 2017 Carlos Neira cneirabustos at gmail.com
>   * All rights reserved.
>   *
>   * Redistribution and use in source and binary forms, with or without
> 
> 

-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-head mailing list