svn commit: r344960 - head/sys/powerpc/powerpc

Alexey Dokuchaev danfe at freebsd.org
Mon Mar 11 06:23:17 UTC 2019


On Sun, Mar 10, 2019 at 05:16:40PM -0500, Justin Hibbits wrote:
> On Sat, 9 Mar 2019 08:50:58 +0000
> Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > On Sat, Mar 09, 2019 at 03:18:38AM +0000, Justin Hibbits wrote:
> > > New Revision: 344960
> > > URL: https://svnweb.freebsd.org/changeset/base/344960
> > > 
> > > Log:
> > >   powerpc: Print trap frame address for fatal traps
> > >   
> > >   MFC after:	1 week
> > > 
> > > Modified: head/sys/powerpc/powerpc/trap.c
> > > ...
> > > current msr     = 0x%" PRIxPTR "\n", mfmsr()); printf("
> > > lr              = 0x%" PRIxPTR " (0x%" PRIxPTR ")\n", frame->lr,
> > > frame->lr - (register_t)(__startkernel - KERNBASE));
> > > +	printf("   frame           = %p\n", frame);
> > >  	printf("   curthread       = %p\n", curthread);
> > 
> > Some of those are printed with %PRIxPTR, some with %p.  Perhaps this
> > inconsistency can be avoided?
> 
> PRIxPTR is for printing a pointer-like value that's not a pointer.
> The other values printed are of type register_t, not void *.

Ah, okay, I've somehow missed that, thanks for pointing this out.

./danfe


More information about the svn-src-head mailing list