svn commit: r344859 - in head: sbin/ifconfig sys/net sys/netinet6

[Rodney W. Grimes]

> On 6 Mar 2019, at 23:39, Rodney W. Grimes wrote:
> 
> >> Author: bz
> >> Date: Wed Mar  6 23:31:42 2019
> >> New Revision: 344859
> >> URL: https://svnweb.freebsd.org/changeset/base/344859
> >>
> >> Log:
> >>   Update for IETF draft-ietf-6man-ipv6only-flag.
> >>
> >>   All changes are hidden behind the EXPERIMENTAL option and are not 
> >> compiled
> >>   in by default.
> >
> > It is probably time to make EXPERIMENTAL finer grain,
> > there are likely more than one experiment to be avaliable
> > in the tree at the same time, and having them all use this
> > one knob is a bit of a pita.
> 
> I added the knob to encourage people putting more stuff under it.

Such as?

> Making it finer grained did not seem to be a good idea at the time.   
> For that we do have individual kernel options.

Which is what I am going to have to do for my "EXPERIMENT" since
I do not want this code in it.  Its fine, but more or less you
have now reserved EXPERIMENT for some subset, and I'll call mine
something like EXPERIMENT_foo

> If you are saying that I should add an extra layer of #ifdef under 
> EXPERIMENTAL such as #ifdef EXP_IPV6_ONLY_FLAG, adding such a kernel 
> option seems plausible though a pain when this either goes away entirely 
> or becomes mainline and in either case would not be under an extra 
> option.

I would of just used #ifdef EXP_IPV6_ONLY_FLAG and not used EXPERIMENTAL
at all.  The #ifdef goes away when it is mainline.

> /bz
-- 
Rod Grimes                                                 rgrimes at freebsd.org