svn commit: r348847 - head/sys/sys

Ian Lepore ian at freebsd.org
Mon Jun 10 15:03:06 UTC 2019


On Mon, 2019-06-10 at 07:49 -0600, Warner Losh wrote:
> On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer <cem at freebsd.org> wrote:
> 
> > On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans <tijl at freebsd.org>
> > wrote:
> > > On Mon, 10 Jun 2019 05:28:04 +0000 (UTC) Dmitry Chagin
> > > <dchagin at FreeBSD.org> wrote:
> > > > ...
> > > > URL: https://svnweb.freebsd.org/changeset/base/348847
> > > > Log:
> > > >   Use C11 anonymous unions.
> > > > 
> > > > Modified: head/sys/sys/ucred.h
> > > 
> > > ...
> > > 
> > > Isn't this a userland header that should work with non-C11
> > > compilers?
> > 
> > Hi Tijl,
> > 
> > Why would one expect userland headers to work with non-C11 (gnu89)
> > compilers?
> > 
> 
> Because those compilers can choose non c11 variants of the language?
> 
> Warner
> 

Do we promise that userland will compile with -std=c89?  I hope not. 
Anonymous unions may be a c11 feature, but they're also available with
-std=gnu99, which I think is how we compile userland.

I think -std=gnu99 is how we should also compile the kernel, and I
think Bruce has been trying to say that for several years (but I'm not
sure, because the emails that seem to say so are always so full of
semi-related extraneous material that it's hard to be sure what they're
saying).

-- Ian




More information about the svn-src-head mailing list