svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb

[Warner Losh]

On Mon, Jun 3, 2019 at 7:54 AM Rodney W. Grimes <freebsd at gndrsh.dnsmgr.net>
wrote:

> > In message <7BD6B7AD-5950-4015-B95D-9FFB609F51E9 at fubar.geek.nz>, Andrew
> Turner
> > writes:
> > >
> > >
> > > > On 3 Jun 2019, at 00:38, Maxim Sobolev <sobomax at freebsd.org> wrote:
> > > >
> > > > Author: sobomax
> > > > Date: Sun Jun  2 23:38:19 2019
> > > > New Revision: 348521
> > > > URL: https://svnweb.freebsd.org/changeset/base/348521
> > > >
> > > > Log:
> > > >  Fix several places where tool name has been hardcoded:
> > > >
> > > >      install -> ${INSTALL}
> > > >      mtree -> ${MTREE_CMD}
> > > >      services_mkdb -> ${SERVICES_MKDB_CMD}
> > > >      cap_mkdb -> ${CAP_MKDB_CMD}
> > > >      pwd_mkdb -> ${PWD_MKDB_CMD}
> > > >      kldxref -> ${KLDXREF_CMD}
> > > >
> > > >  If you do custom FreeBSD builds you may want to override those
> > > >  in some cases.
> > > >
> > > >  Sponsored by:    Sippy Software, Inc.
> > >
> > > This breaks installworld in a local Jenkins instance. I???m building
> with -DD
> > > B_FROM_SRC and -DNO_ROOT. It looks like INSTALL is unset.
> > >
> > > Andrew
> > >
> > > --------------------------------------------------------------
> > > >>> Making hierarchy
> > > --------------------------------------------------------------
> > > cd /jenkins/workspace/FreeBSD-arm64-head/freebsd-head; make -f
> Makefile.inc1
> > >  LOCAL_MTREE= hierarchy
> > > cd /jenkins/workspace/FreeBSD-arm64-head/freebsd-head/etc;
> PATH=/jenkins/work
> ...
> >
> > It also breaks poudirere builds at make distrib-dirs, amd64 and i386,
> i386
> > distrib-dirs on amd64 sample below. The src/etc/Makefile distrib-dirs
> target
> > is the failing one.
>
> Something is pretty broke here then, as INSTALL has been defined for
> ever in sys.mk:
> sys.mk:INSTALL          ?=      install
>

The problem is that MTREE isn't defined, which makes MTREE_CMD start with
-N.

Warner