svn commit: r348504 - in head: lib/clang/libllvm tools/build/mk usr.bin/clang

[Kyle Evans]

On Sun, Jun 2, 2019 at 6:56 AM Shawn Webb <shawn.webb at hardenedbsd.org> wrote:
>
> On Sun, Jun 02, 2019 at 04:04:21AM +0000, Kyle Evans wrote:
> > Author: kevans
> > Date: Sun Jun  2 04:04:21 2019
> > New Revision: 348504
> > URL: https://svnweb.freebsd.org/changeset/base/348504
> >
> > Log:
> >   llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG
> >
> >   ASAN reports become a lot more useful with llvm-symbolizer in $PATH, and the
> >   build is not much more time-consuming. The added benefit is that the
> >   resulting reports will actually include symbol information; without, thread
> >   trace information includes a bunch of addresses that immediately resolve to
> >   an inline function in
> >   ^/contrib/compiler-rt/lib/sanitizer_common/sanitizer_common.h and take a
> >   little more effort to examine.
> >
> >   Reviewed by:        emaste
> >   MFC after:  1 week
> >   Differential Revision:      https://reviews.freebsd.org/D20484
> >
> > Modified:
> >   head/lib/clang/libllvm/Makefile
> >   head/tools/build/mk/OptionalObsoleteFiles.inc
> >   head/usr.bin/clang/Makefile
> >
> > Modified: head/lib/clang/libllvm/Makefile
> > ==============================================================================
> > --- head/lib/clang/libllvm/Makefile   Sun Jun  2 02:38:44 2019        (r348503)
> > +++ head/lib/clang/libllvm/Makefile   Sun Jun  2 04:04:21 2019        (r348504)
> > @@ -523,7 +523,7 @@ SRCS_EXT+=        DebugInfo/PDB/PDBSymbolTypeVTableShape.cpp
> >  SRCS_EXT+=   DebugInfo/PDB/PDBSymbolUnknown.cpp
> >  SRCS_EXT+=   DebugInfo/PDB/PDBSymbolUsingNamespace.cpp
> >  SRCS_EXT+=   DebugInfo/PDB/UDTLayout.cpp
> > -SRCS_EXT+=   DebugInfo/Symbolize/DIPrinter.cpp
> > +SRCS_MIW+=   DebugInfo/Symbolize/DIPrinter.cpp
> >  SRCS_MIW+=   DebugInfo/Symbolize/SymbolizableObjectFile.cpp
> >  SRCS_MIW+=   DebugInfo/Symbolize/Symbolize.cpp
>
> Is SRCS_MIW the right spelling?
>

Yup. Here's my understanding from looking at usage:

SRCS_MIN = Absolute minimum set of src to build libllvm for bootstrap
tools (MIN = MINimum)
SRCS_MIW = Anything else needed to build libllvm for world tools (MIW
= MIn World)

Thanks,

Kyle Evans