svn commit: r348493 - head/sys/dev/sdhci
Bjoern A. Zeeb
bz at FreeBSD.org
Sat Jun 1 14:39:14 UTC 2019
Author: bz
Date: Sat Jun 1 14:39:12 2019
New Revision: 348493
URL: https://svnweb.freebsd.org/changeset/base/348493
Log:
Improve error/debug messages in sdhci.c
When starting a command also print the opcode and flags.
More consitently print flags as hex.
Use slot_printf rather than printf in one case.
MFC after: 6 weeks
Reviewed by: marius, kibab, imp
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D19748
Modified:
head/sys/dev/sdhci/sdhci.c
Modified: head/sys/dev/sdhci/sdhci.c
==============================================================================
--- head/sys/dev/sdhci/sdhci.c Sat Jun 1 13:22:56 2019 (r348492)
+++ head/sys/dev/sdhci/sdhci.c Sat Jun 1 14:39:12 2019 (r348493)
@@ -1762,7 +1762,9 @@ sdhci_start_command(struct sdhci_slot *slot, struct mm
/* Set data transfer mode. */
sdhci_set_transfer_mode(slot, cmd->data);
if (__predict_false(sdhci_debug > 1))
- slot_printf(slot, "Starting command!\n");
+ slot_printf(slot, "Starting command opcode %#04x flags %#04x\n",
+ cmd->opcode, flags);
+
/* Start command. */
WR2(slot, SDHCI_COMMAND_FLAGS, (cmd->opcode << 8) | (flags & 0xff));
/* Start timeout callout. */
@@ -1778,7 +1780,7 @@ sdhci_finish_command(struct sdhci_slot *slot)
uint8_t extra;
if (__predict_false(sdhci_debug > 1))
- slot_printf(slot, "%s: called, err %d flags %d\n",
+ slot_printf(slot, "%s: called, err %d flags %#04x\n",
__func__, slot->curcmd->error, slot->curcmd->flags);
slot->cmd_done = 1;
/*
@@ -1819,7 +1821,7 @@ sdhci_finish_command(struct sdhci_slot *slot)
slot->curcmd->resp[0] = RD4(slot, SDHCI_RESPONSE);
}
if (__predict_false(sdhci_debug > 1))
- printf("Resp: %02x %02x %02x %02x\n",
+ slot_printf(slot, "Resp: %#04x %#04x %#04x %#04x\n",
slot->curcmd->resp[0], slot->curcmd->resp[1],
slot->curcmd->resp[2], slot->curcmd->resp[3]);
More information about the svn-src-head
mailing list