svn commit: r350067 - in head/contrib/netbsd-tests/lib/libc: gen stdio sys
Brooks Davis
brooks at FreeBSD.org
Tue Jul 16 22:27:51 UTC 2019
Author: brooks
Date: Tue Jul 16 22:27:49 2019
New Revision: 350067
URL: https://svnweb.freebsd.org/changeset/base/350067
Log:
Add missing mode in open(2) calls with O_CREAT.
When O_CREAT is specified, the third, variadic argument is
required as the permission. If on is not passed, then depending
on the ABI, either the contents of the third argument register
or some arbitrary stuff on the stack will be used as the permission.
This has been merged to NetBSD.
Reviewed by: asomers, ngie
Obtained from: CheriBSD
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D20972
Modified:
head/contrib/netbsd-tests/lib/libc/gen/t_ftok.c
head/contrib/netbsd-tests/lib/libc/stdio/t_fopen.c
head/contrib/netbsd-tests/lib/libc/sys/t_access.c
head/contrib/netbsd-tests/lib/libc/sys/t_mprotect.c
head/contrib/netbsd-tests/lib/libc/sys/t_stat.c
head/contrib/netbsd-tests/lib/libc/sys/t_write.c
Modified: head/contrib/netbsd-tests/lib/libc/gen/t_ftok.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libc/gen/t_ftok.c Tue Jul 16 19:40:23 2019 (r350066)
+++ head/contrib/netbsd-tests/lib/libc/gen/t_ftok.c Tue Jul 16 22:27:49 2019 (r350067)
@@ -65,7 +65,7 @@ ATF_TC_BODY(ftok_link, tc)
key_t k1, k2, k3;
int fd;
- fd = open(path, O_RDONLY | O_CREAT);
+ fd = open(path, O_RDONLY | O_CREAT, 0600);
ATF_REQUIRE(fd >= 0);
(void)close(fd);
Modified: head/contrib/netbsd-tests/lib/libc/stdio/t_fopen.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libc/stdio/t_fopen.c Tue Jul 16 19:40:23 2019 (r350066)
+++ head/contrib/netbsd-tests/lib/libc/stdio/t_fopen.c Tue Jul 16 22:27:49 2019 (r350067)
@@ -58,7 +58,7 @@ ATF_TC_BODY(fdopen_close, tc)
* used to fdopen(3) a stream is
* closed once the stream is closed.
*/
- fd = open(path, O_RDWR | O_CREAT);
+ fd = open(path, O_RDWR | O_CREAT, 0600);
ATF_REQUIRE(fd >= 0);
@@ -85,7 +85,7 @@ ATF_TC_BODY(fdopen_err, tc)
{
int fd;
- fd = open(path, O_RDONLY | O_CREAT);
+ fd = open(path, O_RDONLY | O_CREAT, 0600);
ATF_REQUIRE(fd >= 0);
errno = 0;
@@ -126,7 +126,7 @@ ATF_TC_BODY(fdopen_seek, tc)
* with the stream corresponds with the offset
* set earlier for the file descriptor.
*/
- fd = open(path, O_RDWR | O_CREAT);
+ fd = open(path, O_RDWR | O_CREAT, 0600);
ATF_REQUIRE(fd >= 0);
ATF_REQUIRE(write(fd, "garbage", 7) == 7);
Modified: head/contrib/netbsd-tests/lib/libc/sys/t_access.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libc/sys/t_access.c Tue Jul 16 19:40:23 2019 (r350066)
+++ head/contrib/netbsd-tests/lib/libc/sys/t_access.c Tue Jul 16 22:27:49 2019 (r350067)
@@ -62,7 +62,7 @@ ATF_TC_BODY(access_access, tc)
size_t i;
int fd;
- fd = open(path, O_RDONLY | O_CREAT);
+ fd = open(path, O_RDONLY | O_CREAT, 0600);
if (fd < 0)
return;
Modified: head/contrib/netbsd-tests/lib/libc/sys/t_mprotect.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libc/sys/t_mprotect.c Tue Jul 16 19:40:23 2019 (r350066)
+++ head/contrib/netbsd-tests/lib/libc/sys/t_mprotect.c Tue Jul 16 22:27:49 2019 (r350067)
@@ -116,7 +116,7 @@ ATF_TC_BODY(mprotect_access, tc)
size_t i;
int fd;
- fd = open(path, O_RDONLY | O_CREAT);
+ fd = open(path, O_RDONLY | O_CREAT, 0600);
ATF_REQUIRE(fd >= 0);
/*
Modified: head/contrib/netbsd-tests/lib/libc/sys/t_stat.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libc/sys/t_stat.c Tue Jul 16 19:40:23 2019 (r350066)
+++ head/contrib/netbsd-tests/lib/libc/sys/t_stat.c Tue Jul 16 22:27:49 2019 (r350067)
@@ -64,7 +64,7 @@ ATF_TC_BODY(stat_chflags, tc)
(void)memset(&sa, 0, sizeof(struct stat));
(void)memset(&sb, 0, sizeof(struct stat));
- fd = open(path, O_RDONLY | O_CREAT);
+ fd = open(path, O_RDONLY | O_CREAT, 0600);
ATF_REQUIRE(fd != -1);
ATF_REQUIRE(stat(path, &sa) == 0);
@@ -210,7 +210,7 @@ ATF_TC_BODY(stat_mtime, tc)
(void)memset(&sa, 0, sizeof(struct stat));
(void)memset(&sb, 0, sizeof(struct stat));
- fd[i] = open(path, O_WRONLY | O_CREAT);
+ fd[i] = open(path, O_WRONLY | O_CREAT, 0600);
ATF_REQUIRE(fd[i] != -1);
ATF_REQUIRE(write(fd[i], "X", 1) == 1);
@@ -254,7 +254,7 @@ ATF_TC_BODY(stat_perm, tc)
uid = getuid();
gid = getgid();
- fd = open(path, O_RDONLY | O_CREAT);
+ fd = open(path, O_RDONLY | O_CREAT, 0600);
ATF_REQUIRE(fd != -1);
ATF_REQUIRE(fstat(fd, &sa) == 0);
@@ -288,7 +288,7 @@ ATF_TC_BODY(stat_size, tc)
size_t i;
int fd;
- fd = open(path, O_WRONLY | O_CREAT);
+ fd = open(path, O_WRONLY | O_CREAT, 0600);
ATF_REQUIRE(fd >= 0);
for (i = 0; i < n; i++) {
@@ -377,7 +377,7 @@ ATF_TC_BODY(stat_symlink, tc)
(void)memset(&sa, 0, sizeof(struct stat));
(void)memset(&sb, 0, sizeof(struct stat));
- fd = open(path, O_WRONLY | O_CREAT);
+ fd = open(path, O_WRONLY | O_CREAT, 0600);
ATF_REQUIRE(fd >= 0);
ATF_REQUIRE(symlink(path, pathlink) == 0);
Modified: head/contrib/netbsd-tests/lib/libc/sys/t_write.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libc/sys/t_write.c Tue Jul 16 19:40:23 2019 (r350066)
+++ head/contrib/netbsd-tests/lib/libc/sys/t_write.c Tue Jul 16 22:27:49 2019 (r350067)
@@ -69,7 +69,7 @@ ATF_TC_BODY(write_err, tc)
errno = 0;
ATF_REQUIRE_ERRNO(EBADF, write(-1, wbuf, sizeof(wbuf)) == -1);
- fd = open(path, O_RDWR | O_CREAT);
+ fd = open(path, O_RDWR | O_CREAT, 0600);
if (fd >= 0) {
@@ -141,7 +141,7 @@ ATF_TC_BODY(write_pos, tc)
size_t i;
int fd;
- fd = open(path, O_RDWR | O_CREAT);
+ fd = open(path, O_RDWR | O_CREAT, 0600);
ATF_REQUIRE(fd >= 0);
for (i = 0; i < n; i++) {
@@ -171,7 +171,7 @@ ATF_TC_BODY(write_ret, tc)
size_t i, j;
int fd;
- fd = open(path, O_WRONLY | O_CREAT);
+ fd = open(path, O_WRONLY | O_CREAT, 0600);
ATF_REQUIRE(fd >= 0);
(void)memset(buf, 'x', sizeof(buf));
More information about the svn-src-head
mailing list