svn commit: r350049 - head/contrib/amd/amd

[Shawn Webb]

On Tue, Jul 16, 2019 at 04:03:08PM +0000, Brooks Davis wrote:
> Author: brooks
> Date: Tue Jul 16 16:03:08 2019
> New Revision: 350049
> URL: https://svnweb.freebsd.org/changeset/base/350049
> 
> Log:
>   Fix two mismatches between function declaration and definition.
>   
>   In both cases, function pointer arguments were inconsistently declared
>   and the result worked because of C's odd rules around function pointer
>   (de)references.  With a stricter compiler these fail to compile.

And, with CFI applied to the kernel, would cause a panic. :)

Good catch and thanks for the great work!

-- 
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

Tor-ified Signal:    +1 443-546-8752
Tor+XMPP+OTR:        lattera at is.a.hacker.sx
GPG Key ID:          0xFF2E67A277F8E1FA
GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9  3633 C85B 0AF8 AB23 0FB2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20190716/f26d46b3/attachment.sig>