svn commit: r350008 - head/sbin/camcontrol

Warner Losh imp at FreeBSD.org
Mon Jul 15 20:25:42 UTC 2019


Author: imp
Date: Mon Jul 15 20:25:41 2019
New Revision: 350008
URL: https://svnweb.freebsd.org/changeset/base/350008

Log:
  Use the more proper term of SATL instead of ATA_BEHIND_SCSI.
  
  Most people know SAS attached SATA devices by the name SAT or SATL
  (with the latter being a little more common). Change the device type
  ATA_BEHIND_SCSI to SATL since it's more specific and meaningful.
  
  Suggested by: scottl@

Modified:
  head/sbin/camcontrol/camcontrol.c
  head/sbin/camcontrol/camcontrol.h
  head/sbin/camcontrol/epc.c
  head/sbin/camcontrol/fwdownload.c
  head/sbin/camcontrol/zone.c

Modified: head/sbin/camcontrol/camcontrol.c
==============================================================================
--- head/sbin/camcontrol/camcontrol.c	Mon Jul 15 20:14:30 2019	(r350007)
+++ head/sbin/camcontrol/camcontrol.c	Mon Jul 15 20:25:41 2019	(r350008)
@@ -5391,7 +5391,7 @@ get_device_type(struct cam_device *dev, int retry_coun
 	retval = dev_has_vpd_page(dev, SVPD_ATA_INFORMATION, retry_count,
 				  timeout, verbosemode);
 	if (retval == 1)
-		*devtype = CC_DT_ATA_BEHIND_SCSI;
+		*devtype = CC_DT_SATL;
 	else
 		*devtype = CC_DT_SCSI;
 

Modified: head/sbin/camcontrol/camcontrol.h
==============================================================================
--- head/sbin/camcontrol/camcontrol.h	Mon Jul 15 20:14:30 2019	(r350007)
+++ head/sbin/camcontrol/camcontrol.h	Mon Jul 15 20:25:41 2019	(r350008)
@@ -42,7 +42,7 @@ typedef enum {
 typedef enum {
 	CC_DT_NONE,
 	CC_DT_SCSI,
-	CC_DT_ATA_BEHIND_SCSI,
+	CC_DT_SATL,
 	CC_DT_ATA,
 	CC_DT_NVME,
 	CC_DT_MMCSD,

Modified: head/sbin/camcontrol/epc.c
==============================================================================
--- head/sbin/camcontrol/epc.c	Mon Jul 15 20:14:30 2019	(r350007)
+++ head/sbin/camcontrol/epc.c	Mon Jul 15 20:25:41 2019	(r350008)
@@ -767,7 +767,7 @@ epc(struct cam_device *device, int argc, char **argv, 
 
 	switch (devtype) {
 	case CC_DT_ATA:
-	case CC_DT_ATA_BEHIND_SCSI:
+	case CC_DT_SATL:
 		break;
 	default:
 		warnx("The epc subcommand only works with ATA protocol "

Modified: head/sbin/camcontrol/fwdownload.c
==============================================================================
--- head/sbin/camcontrol/fwdownload.c	Mon Jul 15 20:14:30 2019	(r350007)
+++ head/sbin/camcontrol/fwdownload.c	Mon Jul 15 20:25:41 2019	(r350008)
@@ -694,7 +694,7 @@ fw_check_device_ready(struct cam_device *dev, camcontr
 		    		     /*sense_len*/ SSD_FULL_SIZE,
 				     /*timeout*/ 5000);
 		break;
-	case CC_DT_ATA_BEHIND_SCSI:
+	case CC_DT_SATL:
 	case CC_DT_ATA: {
 		retval = build_ata_cmd(ccb,
 			     /*retries*/ 1,
@@ -853,7 +853,7 @@ fw_download_img(struct cam_device *cam_dev, struct fw_
 			    timeout ? timeout : WB_TIMEOUT);	/* timeout*/
 			break;
 		case CC_DT_ATA:
-		case CC_DT_ATA_BEHIND_SCSI: {
+		case CC_DT_SATL: {
 			uint32_t	off;
 
 			off = (uint32_t)(pkt_ptr - buf);
@@ -969,7 +969,7 @@ fwdownload(struct cam_device *device, int argc, char *
 		errx(1, "Unable to determine device type");
 
 	if ((devtype == CC_DT_ATA)
-	 || (devtype == CC_DT_ATA_BEHIND_SCSI)) {
+	 || (devtype == CC_DT_SATL)) {
 		ccb = cam_getccb(device);
 		if (ccb == NULL) {
 			warnx("couldn't allocate CCB");

Modified: head/sbin/camcontrol/zone.c
==============================================================================
--- head/sbin/camcontrol/zone.c	Mon Jul 15 20:14:30 2019	(r350007)
+++ head/sbin/camcontrol/zone.c	Mon Jul 15 20:25:41 2019	(r350008)
@@ -466,7 +466,7 @@ restart_report:
 			    /*timeout*/ timeout ? timeout : 60000);
 			break;
 		case CC_DT_ATA:
-		case CC_DT_ATA_BEHIND_SCSI: {
+		case CC_DT_SATL: {
 			uint8_t command = 0;
 			uint8_t protocol = 0;
 			uint16_t features = 0, sector_count = 0;
@@ -558,7 +558,7 @@ restart_report:
 			    /*timeout*/ timeout ? timeout : 60000);
 			break;
 		case CC_DT_ATA:
-		case CC_DT_ATA_BEHIND_SCSI: {
+		case CC_DT_SATL: {
 			uint8_t command = 0;
 			uint8_t protocol = 0;
 			uint16_t features = 0, sector_count = 0;


More information about the svn-src-head mailing list