svn commit: r349752 - head/sys/dev/netmap

Vincenzo Maffione vmaffione at FreeBSD.org
Thu Jul 4 21:11:46 UTC 2019


Author: vmaffione
Date: Thu Jul  4 21:11:45 2019
New Revision: 349752
URL: https://svnweb.freebsd.org/changeset/base/349752

Log:
  netmap: fix kernel pointer printing in netmap_generic.c
  
  Print the adapter name rather than the address of the adapter
  to avoid kernel address leakage.
  
  PR:		Bug 238642
  Submitted by:	Fuqian Huang <huangfq.daxian at gmail.com>
  Reviewed by:	vmaffione
  MFC after:	1 week

Modified:
  head/sys/dev/netmap/netmap_generic.c

Modified: head/sys/dev/netmap/netmap_generic.c
==============================================================================
--- head/sys/dev/netmap/netmap_generic.c	Thu Jul  4 20:42:08 2019	(r349751)
+++ head/sys/dev/netmap/netmap_generic.c	Thu Jul  4 21:11:45 2019	(r349752)
@@ -1024,7 +1024,7 @@ generic_netmap_dtor(struct netmap_adapter *na)
 		         */
 		        netmap_adapter_put(prev_na);
 		}
-		nm_prinf("Native netmap adapter %p restored", prev_na);
+		nm_prinf("Native netmap adapter for %s restored", prev_na->name);
 	}
 	NM_RESTORE_NA(ifp, prev_na);
 	/*
@@ -1126,7 +1126,7 @@ generic_netmap_attach(struct ifnet *ifp)
 
 	nm_os_generic_set_features(gna);
 
-	nm_prinf("Emulated adapter for %s created (prev was %p)", na->name, gna->prev);
+	nm_prinf("Emulated adapter for %s created (prev was %s)", na->name, gna->prev->name);
 
 	return retval;
 }


More information about the svn-src-head mailing list