svn commit: r343543 - head/sbin/bectl/tests

Kyle Evans kevans at FreeBSD.org
Tue Jan 29 04:08:51 UTC 2019


Author: kevans
Date: Tue Jan 29 04:08:49 2019
New Revision: 343543
URL: https://svnweb.freebsd.org/changeset/base/343543

Log:
  bectl(8) test: Force destroy the zpool in cleanup
  
  This is a wild guess as to why bectl tests failed once upon a time in CI,
  given no apparent way to see a transcript of cleanup routines with Kyua. The
  bectl tests construct a new, clean zpool for every test. The failure
  indicated was because of a mount that was leftover from a previous test, but
  the previous test had succeeded so it's not clear how the mount remained
  leftover unless the `zpool get health ${pool}` had somehow failed.
  
  MFC after:	1 week

Modified:
  head/sbin/bectl/tests/bectl_test.sh

Modified: head/sbin/bectl/tests/bectl_test.sh
==============================================================================
--- head/sbin/bectl/tests/bectl_test.sh	Tue Jan 29 03:31:36 2019	(r343542)
+++ head/sbin/bectl/tests/bectl_test.sh	Tue Jan 29 04:08:49 2019	(r343543)
@@ -62,7 +62,7 @@ bectl_cleanup()
 	zpool=$1
 
 	if zpool get health ${zpool} >/dev/null 2>&1; then
-		zpool destroy ${zpool}
+		zpool destroy -f ${zpool}
 	fi
 }
 


More information about the svn-src-head mailing list