svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm

[Ian Lepore]

On Tue, 2019-01-15 at 12:33 -0800, Gleb Smirnoff wrote:
> On Tue, Jan 15, 2019 at 01:20:14PM -0700, Ian Lepore wrote:
> I> On Tue, 2019-01-15 at 12:06 -0800, Gleb Smirnoff wrote:
> I> > On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote:
> I> > J> Why not #include counter.h in the relevant vm_machdep.c files
> I> > instead?
> I> > 
> I> > This also is ugly :( Not sure more or less. Probably less, but I
> I> > urged to plug all possible compilation failures at a time.
> I> > 
> I> > What is ugly is that most files just need counter_u64_t size,
> I> > and they don't use counter(9) KPI.
> I> > 
> I> > The fact that vm_machdep or Linux KPI want to look into internal
> I> > type uma_zone_t is also ugly.
> I> > 
> I> 
> I> Isn't the usual fix for this problem to create a __counter_u64_t
> in
> I> sys/types.h and use it in places where including the full header
> file
> I> is undesirable for some reason?
> 
> I'm inclined to this solution. Do you want to sign up as reviewer? :)
> 

I can barely keep up with reading all my freebsd-related email these
days, I'd better not commit to a review that I may not actually get
around to.  :/

-- Ian