svn commit: r343011 - in head/kerberos5: lib/libasn1 lib/libgssapi_krb5 lib/libhdb lib/libheimntlm lib/libhx509 lib/libkadm5clnt lib/libkadm5srv lib/libkdc lib/libkrb5 lib/libwind libexec/digest-se...

[Rodney W. Grimes]

> In message <201901141617.x0EGHwqQ035748 at pdx.rh.CN85.dnsmgr.net>, 
> "Rodney W. Gri
> mes" writes:
> > > Author: nyan
> > > Date: Mon Jan 14 06:34:54 2019
> > > New Revision: 343011
> > > URL: https://svnweb.freebsd.org/changeset/base/343011
> > > 
> > > Log:
> > >   Use ${SRCTOP}/contrib/com_err/com_err.h instead of the installed com_err.
> > h.
> > >   This fixes build when com_err.h is not installed.
> >
> > Isn't this the general state of affairs for almost all
> > of the source tree?   I would rather see this solved
> > in a general way, rather than sprinkly all this
> > -I${SRCTOP} all over in the tree.
> 
> Agreed however in practice this is fixed when discovered while working 
> on other issues/problems/projects.

This adds another special case that should not exist.

> >
> > It use to be (and maybe still is) required that you run
> > cd $DRCTOP && make includes
> > if you expected new source code to compile.  I expect
> > this has changed, but the just of it should work in
> > some aspect.
> 
> This fixes the potential bug of requiring a header file to be 
> installed. I suspect this to be an oversight at the time.
> 
> Good that it's fixed now.

Something is wrong, as infact com_err.h *IS*
installed as /usr/include/com_err.h

diff /usr/include/com_err.h /usr/src/contrib/com_err/com_err.h


-- 
Rod Grimes                                                 rgrimes at freebsd.org