svn commit: r344666 - head/tools/build/mk

[Enji Cooper]

> On Feb 28, 2019, at 1:47 PM, Kyle Evans <kevans at FreeBSD.org> wrote:
> 
> On Thu, Feb 28, 2019 at 3:44 PM Enji Cooper <yaneurabeya at gmail.com> wrote:
>> 
>> 
>>> On Feb 28, 2019, at 12:48 PM, Bryan Drewery <bdrewery at FreeBSD.org> wrote:
>>> 
>>> Author: bdrewery
>>> Date: Thu Feb 28 20:48:18 2019
>>> New Revision: 344666
>>> URL: https://svnweb.freebsd.org/changeset/base/344666
>>> 
>>> Log:
>>> bsd.nls.mk isn't optional.
>>> 
>>> It is protected by MK_NLS.  If it should really be optional then

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ To paraphrase Faith No More’s - Epic: “what is ‘It’?" ^^^^^^^^^^^^^^^^^^^^^^^^^^^

> If we actually conditionally installed it, sure- it was only removed
> because of r335011, so it would go through an install/remove dance
> between installworld and delete-old on WITHOUT_NLS systems.

Oh… you’re right. The commit message mislead me to think that it was conditionally installed, but it’s actually always installed.

> If we're going to make it conditional on MK_NLS, it needs to actually
> be conditional on MK_NLS the proper way along with an
> s/.include/.sinclude/.

This is what I was implying ;)…

Cheers,
-Enji