svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec

[John Baldwin]

On 2/26/19 5:49 AM, Alexey Dokuchaev wrote:
> On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote:
>>> Author: sjg
>>> Date: Tue Feb 26 06:17:23 2019
>>> New Revision: 344567
>>> URL: https://svnweb.freebsd.org/changeset/base/344567
>>>
>>> Log:
>>>   Add verifying manifest loader for mac_veriexec
>>>   
>>>   This tool will verify a signed manifest and load contents into
>>>   mac_veriexec for storage
>>>   
>>>   Sponsored by:	Juniper Networks
>>>   Differential Revision:	D16575
>>
>> Just a small nit, for future reference, from the template:
>>> Differential Revision:    https://reviews.freebsd.org/D###
>> (*full* phabric URL needed).
> 
> IMHO we should just fix the scripts to accept D#### alone, without
> the URL.  We don't do that for PR (bugzilla) references, and the fact
> that we do for the phab is both needless and confusing.  Also, that
> URL might change one day while we could probably keep the old numbers
> if we move.

It makes the review clickable in many mail clients which is very handy.
(I use that very often.)  The URL is already generic (reviews.freebsd.org
rather than phabricator.freebsd.org) to accommodate any future replacements
of phab with something else.

You are more than welcome to submit patches to phab.  Getting it to honor
our template so one could just use 'arc commit' directly would probably be
an even bigger win than honoring D<xxxx> in this field, though the second
task is probably simpler?

-- 
John Baldwin