svn commit: r344473 - head/sys/dev/pms/RefTisa/tisa/sassata/sas/ini

[David Bright]

Author: dab
Date: Fri Feb 22 18:43:27 2019
New Revision: 344473
URL: https://svnweb.freebsd.org/changeset/base/344473

Log:
  CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c
  
  A pointer is first tested for NULL. If non-NULL, another pointer is
  set equal to the first. The second pointer is then checked for NULL
  and an error path taken if so. This second test and the associated
  path is dead code as the pointer value, having just been checked for
  NULL, cannot be NULL at this point. Remove the dead code.
  
  Reported by:	Coverity
  Reviewed by:	daniel.william.ryan_gmail.com, vangyzen
  Sponsored by:	Dell EMC Isilon
  Differential Revision:	https://reviews.freebsd.org/D19165

Modified:
  head/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c

Modified: head/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c
==============================================================================
--- head/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c	Fri Feb 22 18:24:57 2019	(r344472)
+++ head/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c	Fri Feb 22 18:43:27 2019	(r344473)
@@ -1820,12 +1820,6 @@ tiNumOfLunIOCTLreq(
       break;
     }
     tdIORequestBody = (tdIORequestBody_t *)tiRequestBody;
-    
-    if(tdIORequestBody == agNULL)
-    {
-      status = IOCTL_CALL_FAIL;
-      break;
-    }
     tdIORequestBody->tiIORequest = tiIORequest;
     
     /* save context if we need to abort later */