svn commit: r344129 - head

Rodney W. Grimes freebsd at pdx.rh.CN85.dnsmgr.net
Thu Feb 14 20:42:31 UTC 2019


> On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote:
> > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes <
> > > >   Differential Review: https://reviews.freebsd.org/D19193
> > >
> > > You sited a differential, but not give any attribution
> > > to the external source :-(
> > >
> > 
> > The differential review has that information.
> 
> External contributors should be recognized by having their names appear
> in the commit logs.

We even bother to put a special line in the commit template
for this.  Further it has been standard operating procedure
for at least as long as I have been back that submitters
are infact recognized in commit messages.

You have, again, summarily dismissed valid feedback.

-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-head mailing list