svn commit: r343746 - head/sys/conf

[Michael Tuexen]

> On 10. Feb 2019, at 08:50, Conrad Meyer <cem at FreeBSD.org> wrote:
> 
> Hi Andrew,
> 
> This makes it compile, but instead of a build failure the kernel is
> broken hard at runtime in early boot with GCC < 8.1.  E.g.,
> amd64-xtoolchain-gcc standard cross-toolchain is still on GCC 6.4.0.
> 
> HEAD GENERIC has been broken in one form or another for xtoolchain GCC
> since r343713 (Feb 3), so I'm going to go ahead and turn this option
> off in GENERIC.  Feel free to reenable when you've tested that it
> works.
Hi Conrad,

does https://reviews.freebsd.org/D19135 fix the issue you are observing?

Best regards
Michael
> 
> Best,
> Conrad
> 
> On Mon, Feb 4, 2019 at 8:55 AM Andrew Turner <andrew at freebsd.org> wrote:
>> 
>> Author: andrew
>> Date: Mon Feb  4 16:55:24 2019
>> New Revision: 343746
>> URL: https://svnweb.freebsd.org/changeset/base/343746
>> 
>> Log:
>>  Only enable trace-cmp on Clang and modern GCC.
>> 
>>  It's was only added to GCC 8.1 so don't try to enable it for earlier
>>  releases.
>> 
>>  Reported by:  lwhsu
>>  Sponsored by: DARPA, AFRL
>> 
>> Modified:
>>  head/sys/conf/files
>>  head/sys/conf/kern.pre.mk
>> 
>> Modified: head/sys/conf/files
>> ==============================================================================
>> --- head/sys/conf/files Mon Feb  4 16:13:41 2019        (r343745)
>> +++ head/sys/conf/files Mon Feb  4 16:55:24 2019        (r343746)
>> @@ -3808,7 +3808,7 @@ kern/kern_idle.c          standard
>> kern/kern_intr.c               standard
>> kern/kern_jail.c               standard
>> kern/kern_kcov.c               optional kcov                   \
>> -       compile-with            "${NORMAL_C} -fno-sanitize-coverage=trace-pc,trace-cmp"
>> +       compile-with            "${NORMAL_C} -fno-sanitize=all"
>> kern/kern_khelp.c              standard
>> kern/kern_kthread.c            standard
>> kern/kern_ktr.c                        optional ktr
>> 
>> Modified: head/sys/conf/kern.pre.mk
>> ==============================================================================
>> --- head/sys/conf/kern.pre.mk   Mon Feb  4 16:13:41 2019        (r343745)
>> +++ head/sys/conf/kern.pre.mk   Mon Feb  4 16:55:24 2019        (r343746)
>> @@ -120,7 +120,12 @@ SAN_CFLAGS+=       -fsanitize=undefined
>> 
>> COVERAGE_ENABLED!=     grep COVERAGE opt_global.h || true ; echo
>> .if !empty(COVERAGE_ENABLED)
>> +.if ${COMPILER_TYPE} == "clang" || \
>> +    (${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 80100)
>> SAN_CFLAGS+=   -fsanitize-coverage=trace-pc,trace-cmp
>> +.else
>> +SAN_CFLAGS+=   -fsanitize-coverage=trace-pc
>> +.endif
>> .endif
>> 
>> CFLAGS+=       ${SAN_CFLAGS}
>> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5387 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20190210/f4197202/attachment-0001.bin>