svn commit: r325728 - head/lib/libkvm

Will Andrews will at firepipe.net
Wed Feb 6 17:29:52 UTC 2019


On Tue, Feb 5, 2019 at 10:25 AM Bruce Evans <brde at optusnet.com.au> wrote:

> Signed kp_offset seems wrong.  Apart from it not reaching the top of 64-
> bit address spaces, adding unsigned kp_len to it gives an unsigned type.
>

It's appropriate, because in this context, we return page information
including addresses that would be valid pointer references, but are not
included in the core file.  Minidumps omit large numbers of physical pages,
so calls to kvm_walk_pages() will generate large numbers of kvm_page
instances that have an offset of -1.

--Will.


More information about the svn-src-head mailing list