svn commit: r355609 - head

[Bryan Drewery]

On 12/11/2019 6:54 AM, Ed Maste wrote:
> Author: emaste
> Date: Wed Dec 11 14:54:29 2019
> New Revision: 355609
> URL: https://svnweb.freebsd.org/changeset/base/355609
> 
> Log:
>   Make NOCLEAN an error instead of a warning
>   
>   The warning was added in r289728 (over four years ago) and at that time
>   NO_CLEAN was already the correct spelling for over a decade.
>   
>   Make NOCLEAN an error as the next step to removing these backward
>   compatibility shims.
> 
> Modified:
>   head/Makefile.inc1
> 
> Modified: head/Makefile.inc1
> ==============================================================================
> --- head/Makefile.inc1	Wed Dec 11 14:28:13 2019	(r355608)
> +++ head/Makefile.inc1	Wed Dec 11 14:54:29 2019	(r355609)
> @@ -458,8 +458,7 @@ SUBDIR+=etc
>  .endif	# !empty(SUBDIR_OVERRIDE)
>  
>  .if defined(NOCLEAN)
> -.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
> -NO_CLEAN=	${NOCLEAN}
> +.error NOCLEAN option is deprecated. Use NO_CLEAN instead.
>  .endif
>  .if defined(NO_CLEANDIR)
>  CLEANDIR=	clean cleandepend
> 

What ever happened to POLA?

Name 1 good reason this should be an .error?! Or even a .warning for
that matter.

The argument I keep hearing is "we have to maintain these 3 lines of
code", ok, well now it's just an annoyance to maintain with no benefit
to the user.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20191212/1f6650be/attachment.sig>